Commit d86c32c2 by Tomas Dvorak

maxDepth param fixed

parent 999c3792
...@@ -11,7 +11,7 @@ import org.junit.Test; ...@@ -11,7 +11,7 @@ import org.junit.Test;
public class MaxDepthAnalysisTest { public class MaxDepthAnalysisTest {
private static final double EXPECTED_PERCENTS = 100; //TODO: why documentation mentions be 16.66666666666666, when there is only one document at all ? private static final double EXPECTED_PERCENTS = 100;
private Variety variety; private Variety variety;
@Before @Before
...@@ -47,8 +47,7 @@ public class MaxDepthAnalysisTest { ...@@ -47,8 +47,7 @@ public class MaxDepthAnalysisTest {
public void testLimitedDepthAnalysis() throws Exception { public void testLimitedDepthAnalysis() throws Exception {
final VarietyAnalysis analysis = variety.withMaxDepth(3).runAnalysis(); final VarietyAnalysis analysis = variety.withMaxDepth(3).runAnalysis();
// TODO: depth 3 means 'someNestedObject.a.b' or 'someNestedObject.a.b.c'? Documentation describes the first variant, variety counts also second. Assert.assertEquals("Variety results have not correct count of entries", 5, analysis.getResultsCollection().count()); // 5 results, including '_id' and 'name'
// FIXME: Assert.assertEquals("Variety results have not correct count of entries", 5, analysis.getResultsCollection().count()); // 5 results, including '_id' and 'name'
analysis.verifyResult("_id", 1, EXPECTED_PERCENTS, "ObjectId"); analysis.verifyResult("_id", 1, EXPECTED_PERCENTS, "ObjectId");
analysis.verifyResult("name", 1, EXPECTED_PERCENTS, "String"); analysis.verifyResult("name", 1, EXPECTED_PERCENTS, "String");
......
...@@ -128,7 +128,7 @@ function serializeDoc(doc, maxDepth){ ...@@ -128,7 +128,7 @@ function serializeDoc(doc, maxDepth){
//if(typeof value != 'object') //if(typeof value != 'object')
result[parentKey+key] = value; result[parentKey+key] = value;
//it's an object, recurse...only if we haven't reached max depth //it's an object, recurse...only if we haven't reached max depth
if(isHash(value) && (maxDepth > 0)) { if(isHash(value) && (maxDepth > 1)) {
serialize(value, parentKey+key+'.',maxDepth-1); serialize(value, parentKey+key+'.',maxDepth-1);
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment