Fixed CWE367: use symbols defined in config.json (#28)

CHANGES.md

@@ -2,6 +2,7 @@ dev
 ====
 
 -   Added more documentation to checks (PR #26)
+-   Fixed check CWE367: use symbols defined in config.json (PR #28)
 
 0.2 (2019-06-25)
 =====

src/checkers/cwe_367.ml

@@ -34,7 +34,9 @@ let is_reachable sub source sink =
   let sink_blk = get_blk_tid_of_tid sub sink_tid in
   Graphlib.Std.Graphlib.is_reachable (module Graphs.Tid) cfg source_blk sink_blk
 
-let handle_sub sub program tid_map _symbols source sink =
+let handle_sub sub program tid_map _symbols source_sink_pair =
+  match source_sink_pair with
+  | [source;sink;] -> begin
       if (Symbol_utils.sub_calls_symbol program sub source) && (Symbol_utils.sub_calls_symbol program sub sink) then
         begin
           let calls = Symbol_utils.get_direct_callsites_of_sub sub in
@@ -56,7 +58,10 @@ let handle_sub sub program tid_map _symbols source sink =
         end
       else
         ()
+    end
+  | _ -> ()
 
-let check_cwe program _proj tid_map _symbol_pairs _ =
-  let symbols = Symbol_utils.build_symbols ["access"; "open";] in
-  Seq.iter (Term.enum sub_t program) ~f:(fun s -> handle_sub s program tid_map symbols "access" "open")
+let check_cwe program _proj tid_map symbol_pairs _ =
+  List.iter symbol_pairs ~f:(fun current_pair -> 
+  let symbols = Symbol_utils.build_symbols current_pair in
+  Seq.iter (Term.enum sub_t program) ~f:(fun s -> handle_sub s program tid_map symbols current_pair))